incorrect help message causing confusion

Asked by Akshay Jain

on product form there is a field UOM -> UOS Coeff and help message of this field says "uom = uos * coeff" whereas in the whole of openerp the calculation is done by "uom = uos / coeff".

I believe this may be a small thing for a developer but for a user this is a huge bug causing lots of confusion and should be rectified.

Question information

Language:
English Edit question
Status:
Solved
For:
Odoo Addons (MOVED TO GITHUB) Edit question
Assignee:
No assignee Edit question
Solved by:
Jay Vora (Serpent Consulting Services)
Solved:
Last query:
Last reply:
Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) said :
#1

Hello Akshay Jain ,

if uom categories are different for purchasing and selling then we can use these field, means if u are purchasing in 'KG' and selling in 'UNIT' then we need some factor to make them unique.
UOM object field measure factor is functional field which is calculated on the bases of rate (1/rate).

Hope this will help you.
Thanks.

Revision history for this message
Akshay Jain (akshay-jain-7983) said :
#2

I m not asking any question here but telling my observation of a bug in openerp. I perfectly understand the coefficient fields. I am saying is that the help message on UOM -> UOS Coeff field is "uom = uos * coeff" but on sale order line form and other forms where this relationship is used, the actual calculation is done as "uom = uos / coeff" which is NOT same as help message. For instance check line number 894 of sale.py file in sale module. That line is 'product_uom_qty': product_uos_qty / product.uos_coeff

Is this calculation according to help message?? NOOOOO it is not. There is a big disparity between help message formula and actual calculation in openerp. So please rectify the help message.

Let me know if i m not clear.

Revision history for this message
Best Jay Vora (Serpent Consulting Services) (jayvora) said :
#3

Hello Akshay,

The current help is absolutely up-to-the point.

I am explaining the use.
Product A has uom PCE and uos XPCE and co-efficient is set to 3.
Create a Sale order, Add one line for SO set qty=5 and do onchange of A.
Now, you have a look at extra info tab of SOLine. It will be 15 as UOS and unit will be XPCE.

That brings the calculation like UOS = UOM * co-efficent.

Everything is quite normal till now.
The code you point out is for Onchange of UOS.
if UOS = UOM * co-efficent , then undoubtedly UOM = UOS / co-efficent.

If I change UOS to be 30, then uom has to be 10.

I hope its clear. so the help should go as UOS = uom * co-ef.

Thank you for your time.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) said :
#4

Corrections have been made by revision 2607 <email address hidden>.
Thanks.

Revision history for this message
Akshay Jain (akshay-jain-7983) said :
#5

Hey Jay, I m myself a computer science engineer and was good at mathematics in college, so I perfectly understand what coefficients mean. And since i was myself a Java software developer till a few months back so from my experience i know how important it is for a s/w to have a good UI and thats why i stressed on having correct help message.

I have revision 2598 with me and it shows help as "uom = uos * coeff" which is not correct and now u also agree on that.

Now if it is rectified in revision 2067 (timestamp tells me it is done on 25-Feb-2010 means yesterday only after it was brought to your team's notice by me) i will update my copy and let you know.

Thanks!!

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) said :
#6

Hello Akshay,

Kindly, don't take the explanation wrong way.

I have corrected the help only after you pointed out. We are thankful to you and we appreciate your interest.

I had explained in full text only due to the reason that the discussions/bug/everything on Launchpad is open for all users, not only those who participate in question.

My clean purpose was just to make all users realize that the change suggested by Akshay Jain is pretty proper and perfectly pointed to technical and functional manner. And, Luckily the change has been on stable version now.

I apologize if it has hurt you anyhow.

With Sincere apologies,thank you.

Revision history for this message
Akshay Jain (akshay-jain-7983) said :
#7

Its ok. I understand that ur explanation will help people doing google search on openerp problems. I just got a little irritated but otherwise no hard feelings. May be i used the wrong words. So please accept my apologies as what u did was right for a bigger cause.

I am a big fan of open source and now i m greatly impressed with your team's efforts. I suggest that u tell your marketing guys to venture more into India as India has a huge SME sector which simply cannot afford the costly ERP like SAP and JD. Most of the SME in India use the Tally for accounts and maintain tons of excel sheets for contacts/hr/stock/sale/purchase management operations. OpenERP has therefore got huge huge potential in India as serious competitor to SAP and Tally. May be u can suggest to Tiny's marketing division to think of India as a serious market.

And you guys are doing a tremendous job. Cheers to open erp team!!!

Revision history for this message
Akshay Jain (akshay-jain-7983) said :
#8

Thanks Jay (Open ERP), that solved my question.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) said :
#9

Hi Akshay,

Thank you for your precious words.

We will definately move towards the concerned approach.

OpenERP Team is honored to have contributors/community members like you.

Thank you again.