MariaDB

innobase not completely decoupled with sql layer

Asked by Lewis Chan

I find that in storage/innobase, there're fewer sql_** includes than mysql's storage/innobase. I guess someone refactored so that storage engine depends upper layer as less as possible, right ? May I see that MDEV ?

As for the left include such as `#include "sql_class.h"`, `#include "sql_error.h"`, there're no way to extract them out of the storage/innobase ?

Question information

Language:
English Edit question
Status:
Solved
For:
MariaDB Edit question
Assignee:
No assignee Edit question
Solved by:
Sergei Golubchik
Solved:
Last query:
Last reply:
Revision history for this message
Best Sergei Golubchik (sergii) said : 		#1

This was likely the other way around. In MySQL-5.5/MariaDB-5.5 storage/innobase had very few server includes. Apparently in MySQL InnoDB got to depend on the server more over time, while in MariaDB it did not.

Revision history for this message
Sergei Golubchik (sergii) said : 		#2

sql_error.h is easy to get rid of. sql_print_warning should be replaced with my_printf_error. sql_class.h is tricker, it's for something we don't have a proper service yet.

Revision history for this message
Lewis Chan (baiwfg2) said : 		#3

Thanks Sergei Golubchik, that solved my question.