dkimpy

Python Style Compliance?

Asked by Thomas Ward

Digging into the code for dkimpy, in order to better determine how we could better document that when an RFC822 formatted message is passed in it should be done so as bytes, I discovered a *whole host* of style issues, including indents that aren't multiples of four, an insufficient number of line breaks between class definitions, etc.

Would a patch that helps to conform to PEP8 a little bit better be welcome?

Question information

Language:
English Edit question
Status:
Answered
For:
dkimpy Edit question
Assignee:
No assignee Edit question
Last query:
Last reply:
Revision history for this message
Scott Kitterman (kitterman) said : 		#1

The original code that we forked from in 2011 had lots of style issues that we have not gone back and fixed. In many places there are two vice four space indents and that's to keep the history readable. I've been gradually changing that when I was touching parts of the code for other reasons, but don't want a global change for it.

Other than that, such a change would be welcome. Particularly things like incorrect number of blank lines are good to fix because they don't lead to any confusion about when code was last touched when you run git blame.

Thanks for considering to contribute.

Can you help with this problem?

Provide an answer of your own, or ask Thomas Ward for more information if necessary.

To post a message you must log in.