Is it normal for 0.4.16 to have 3 errors in tests?

On Thu, 2009-01-01 at 20:36 +0000, Marcin Zajaczkowski wrote:
> I would like to ask is it ok (nothing to worry about) to have 3 errors in tests (make check) with bzr-svn 0.4.16, bazaar 1.10, python 2.5.1 (Fedora 8):
> ERROR: test_get_log (bzrlib.plugins.svn.tests.test_ra.TestRemoteAccess)
> ERROR: test_control_code_msg (bzrlib.plugins.svn.tests.test_repository.TestSubversionRepositoryWorks)
> ERROR: test_knit_corruption (bzrlib.plugins.svn.tests.test_blackbox.TestBranch) ?
No, the tests shouldn't fail in any release. What are the messages with
which these are failing?

Cheers,

Jelmer

--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

I didn't it on another machine also with Fedora 8 and there is only 2 error. Tomorrow I will try on previously mentioned system.
The complete output:

[szpak@szpak bzr-svn-0.4.16]$ make check
/usr/bin/python ./setup.py build_ext --inplace
running build_ext
BZR_PLUGIN_PATH=/home/szpak/foo/u/bzr-svn-0.4.16/.plugins /usr/bin/python /usr/bin/bzr selftest --starting-with=bzrlib.plugins.svn
testing: /usr/bin/bzr
   /usr/lib/python2.5/site-packages/bzrlib (1.10 python2.5.1)

XFAIL: bzrlib.plugins.svn.tests.test_fetch.TestFetchWorks.test_fetch_symlink_with_newlines
Bazaar doesn't support newlines in symlink targets

ERROR: bzrlib.plugins.svn.tests.test_ra.TestRemoteAccess.test_get_log
    need more than 3 values to unpack

ERROR: bzrlib.plugins.svn.tests.test_repository.TestSubversionRepositoryWorks.test_control_code_msg
    'utf8' codec can't decode bytes in position 3-6: unexpected end of data

[945/990 in 8m1s, 2 err] bzrlib.plugins.svn.tests.test_workingtree.TestWorkingTree.test_move /usr/lib/python2.5/site-packages/bzrlib/lockable_files.py:116: UserWarning: LockableFiles(<bzrlib.transport.local.LocalTransport url=file:///tmp/testbzr--H6VrS.tmp/bzrlib.plugins.svn.tests.test_workingtree.TestWorkingTree.test_lock_read/work/dc/.svn/bzr/>) was gc'd while locked
  warnings.warn("%r was gc'd while locked" % self)
/usr/lib/python2.5/site-packages/bzrlib/lockable_files.py:116: UserWarning: LockableFiles(<bzrlib.transport.local.LocalTransport url=file:///tmp/testbzr--H6VrS.tmp/bzrlib.plugins.svn.tests.test_workingtree.TestWorkingTree.test_lock_write/work/dc/.svn/bzr/>) was gc'd while locked
  warnings.warn("%r was gc'd while locked" % self)
XFAIL: bzrlib.plugins.svn.tests.test_workingtree.TestWorkingTree.test_revert
revert not supported yet

XFAIL: bzrlib.plugins.svn.tests.test_blackbox.TestBranch.test_dpush_wt_diff

[990/990 in 9m0s, 2 err] bzrlib.plugins.svn.tests.test_blackbox.TestBranch.test_sign_my_commits
======================================================================
ERROR: test_get_log (bzrlib.plugins.svn.tests.test_ra.TestRemoteAccess)

vvvv[log from bzrlib.plugins.svn.tests.test_ra.TestRemoteAccess.test_get_log]-
245.728 opening working tree '/tmp/testbzr--H6VrS.tmp'

^^^^[log from bzrlib.plugins.svn.tests.test_ra.TestRemoteAccess.test_get_log]-
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/tests/test_ra.py", line 122, in test_get_log
    check_results(returned)
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/tests/test_ra.py", line 107, in check_results
    (paths, revnum, props, has_children) = returned[0]
ValueError: need more than 3 values to unpack

======================================================================
ERROR: test_control_code_msg (bzrlib.plugins.svn.tests.test_repository.TestSubversionRepositoryWorks)

vvvv[log from bzrlib.plugins.svn.tests.test_repository.TestSubversionRepositoryWorks.test_control_code_msg]
263.654 opening SVN RA connection to 'file:///tmp/testbzr--H6VrS.tmp/bzrlib.plugins.svn.tests.test_repository.TestSubversionRepositoryWorks.test_control_code_msg/work/d'
263.656 creating config directory: '/tmp/testbzr--H6VrS.tmp/bzrlib.plugins.svn.tests.test_repository.TestSubversionRepositoryWorks.test_control_code_msg/home/.bazaar'
    INFO Initialising Subversion metadata cache in /tmp/testbzr--H6VrS.tmp/bzrlib.plugins.svn.tests.test_repository.TestSubversionRepositoryWorks.test_control_code_msg/home/.bazaar/svn-cache/4fe257e5-c839-4a9e-8c53-76eaf43fb181
263.896 opening working tree '/tmp/testbzr--H6VrS.tmp'

^^^^[log from bzrlib.plugins.svn.tests.test_repository.TestSubversionRepositoryWorks.test_control_code_msg]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/tests/test_repository.py", line 1174, in test_control_code_msg
    set_branching_scheme(oldrepos, TrunkBranchingScheme())
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/mapping3/__init__.py", line 213, in set_branching_scheme
    repository.get_mapping().scheme = scheme
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/repository.py", line 330, in get_mapping
    self._default_mapping = get_default_mapping().from_repository(self, self._hinted_branch_path)
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/mapping3/__init__.py", line 249, in from_repository
    (guessed_scheme, actual_scheme) = repository_guess_scheme(repository, last_revnum, _hinted_branch_path)
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/mapping3/__init__.py", line 196, in repository_guess_scheme
    repository._log.iter_changes(None, last_revnum, max(0, last_revnum-SCHEME_GUESS_SAMPLE_SIZE), pb=pb), last_revnum, branch_path)
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/mapping3/scheme.py", line 488, in guess_scheme_from_history
    for (revpaths, revnum, revprops) in changed_paths:
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/logwalker.py", line 310, in iter_changes
    self.fetch_revisions(max(from_revnum, to_revnum), pb=pb)
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/logwalker.py", line 466, in fetch_revisions
    self.actual._transport.get_log(rcvr, [""], self.saved_revnum, to_revnum, 0, True, True, False, todo_revprops)
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/transport.py", line 344, in get_log
    revprops)
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/logwalker.py", line 451, in rcvr
    self.cache.insert_revprops(revision, revprops)
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/logwalker.py", line 231, in insert_revprops
    self.insert_revprop(revision, k, v)
  File "/home/szpak/foo/u/bzr-svn-0.4.16/.plugins/svn/logwalker.py", line 225, in insert_revprop
    self.cachedb.execute("replace into revprop (rev, name, value) values (?, ?, ?)", (rev, name.decode("utf-8"), value.decode("utf-8")))
  File "/usr/lib/python2.5/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode bytes in position 3-6: unexpected end of data

----------------------------------------------------------------------
Ran 990 tests in 540.180s

FAILED (errors=2, known_failure_count=3)
12 tests skipped
tests failed
make: *** [check] Error 1

This question was expired because it remained in the 'Open' state without activity for the last 15 days.

Thanks.

The first issue is already fixed in bzr-svn 0.5.0. I've now also fixed
the second (which will only occur against subversion 1.4) in subvertpy.
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

answered